drew/acadia
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

[Glacier] Update String to be non-copyable by default.

Browse source
This commit is contained in:
Drew Galbraith 2023-11-19 19:14:37 -08:00
parent ced89834de
commit 337126cabb
10 changed files with 39 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/glacier/string/str_format.cpp
View file

@ -70,11 +70,6 @@ void StrFormatValue(StringBuilder& builder, StringView value, StringView opts) {
StrFormatInternal(builder, value);
}
template <>
void StrFormatValue(StringBuilder& builder, String value, StringView opts) {
StrFormatInternal(builder, value);
}
void StrFormatInternal(StringBuilder& builder, StringView format) {
// TODO: Consider throwing an error if there are unhandled format
builder.PushBack(format);

3
lib/glacier/string/str_format.h
View file

@ -37,9 +37,6 @@ void StrFormatValue(StringBuilder& builder, const char* value, StringView opts);
template <>
void StrFormatValue(StringBuilder& builder, StringView value, StringView opts);
template <>
void StrFormatValue(StringBuilder& builder, String value, StringView opts);
void StrFormatInternal(StringBuilder& builder, StringView format);
template <typename T, typename... Args>

1
lib/glacier/string/string.cpp
View file

@ -46,5 +46,6 @@ char String::operator[](uint64_t offset) const {
}
String::operator StringView() const { return StringView(cstr_, length_); }
StringView String::view() const { return this->operator StringView(); }
} // namespace glcr

4
lib/glacier/string/string.h
View file

@ -13,13 +13,17 @@ class String {
String(const char* cstr, uint64_t str_len);
String(StringView str);
String(const String&) = delete;
const char* cstr() const { return cstr_; }
uint64_t length() const { return length_; }
bool operator==(const String& str);
char operator[](uint64_t offset) const;
operator StringView() const;
StringView view() const;
private:
char* cstr_;