drew/acadia
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

Move glcr::Array & glcr::ArrayView loops to range-based.

Browse source
This commit is contained in:
Drew Galbraith 2024-01-11 17:39:55 -08:00
parent 0a57d149b6
commit 5eb72da9c8
3 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
zion/syscall/ipc.cpp
View file

@ -28,12 +28,12 @@ glcr::ErrorOr<IpcMessage> TranslateRequestToIpcMessage(const T& req) {
glcr::ArrayView<const z_cap_t> caps(req.caps, req.num_caps);
message.caps.Resize(caps.size());
for (uint64_t i = 0; i < caps.size(); i++) {
for (uint64_t capid : caps) {
// FIXME: This would feel safer closer to the relevant syscall.
// FIXME: Race conditions on get->check->release here. Would be better to
// have that as a single call on the process. (This pattern repeats other
// places too).
auto cap = gScheduler->CurrentProcess().GetCapability(caps[i]);
auto cap = gScheduler->CurrentProcess().GetCapability(capid);
if (!cap) {
return glcr::CAP_NOT_FOUND;
}
@ -41,7 +41,7 @@ glcr::ErrorOr<IpcMessage> TranslateRequestToIpcMessage(const T& req) {
return glcr::CAP_PERMISSION_DENIED;
}
message.caps.PushBack(
gScheduler->CurrentProcess().ReleaseCapability(caps[i]));
gScheduler->CurrentProcess().ReleaseCapability(capid));
}
return message;