drew/acadia
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

[zion] Store capability ids on the CapabilityTable.

Browse source 
This is preferable to storing it in the capability itself since the id
is really just an index for the containing process.
This commit is contained in:
Drew Galbraith 2023-06-16 15:27:09 -07:00
parent b27672d5de
commit 75b1f2d21c
3 changed files with 21 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
zion/capability/capability_table.cpp
View file

@ -4,17 +4,17 @@ CapabilityTable::CapabilityTable() {}
uint64_t CapabilityTable::AddExistingCapability(const RefPtr<Capability>& cap) {
MutexHolder h(lock_);
cap->set_id(next_cap_id_++);
capabilities_.PushBack(cap);
return cap->id();
uint64_t id = next_cap_id_++;
capabilities_.PushBack({.id = id, .cap = cap});
return id;
}
RefPtr<Capability> CapabilityTable::GetCapability(uint64_t id) {
MutexHolder h(lock_);
auto iter = capabilities_.begin();
while (iter != capabilities_.end()) {
if (*iter && (*iter)->id() == id) {
return *iter;
if (iter->cap && iter->id == id) {
return iter->cap;
}
++iter;
}
@ -27,10 +27,10 @@ RefPtr<Capability> CapabilityTable::ReleaseCapability(uint64_t id) {
MutexHolder h(lock_);
auto iter = capabilities_.begin();
while (iter != capabilities_.end()) {
if (*iter && (*iter)->id() == id) {
if (iter->cap && iter->id == id) {
// FIXME: Do an actual release here.
auto cap = *iter;
*iter = {nullptr};
auto cap = iter->cap;
iter->cap = {nullptr};
return cap;
}
++iter;