drew/acadia
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

[zion] Dynamically check Capability type.

Browse source 
Instead of passing an enum with the capability when creating it, relying
on polymorphism and a template struct tag to determine the object type
at runtime.

This is cleaner and avoids errors where we pass the wrong capability
type with the cap and do a bad cast at runtime.
This commit is contained in:
Drew Galbraith 2023-06-16 14:53:57 -07:00
parent b4902a79ef
commit a47bac9966
13 changed files with 113 additions and 106 deletions
Download patch file Download diff file Expand all files Collapse all files

20
zion/object/process.cpp
View file

@ -23,10 +23,8 @@ RefPtr<Process> Process::RootProcess() {
RefPtr<Process> Process::Create() {
auto proc = MakeRefCounted<Process>();
proc->caps_.AddNewCapabilityWithId(Z_INIT_PROC_SELF, proc,
Capability::PROCESS,
ZC_PROC_SPAWN_PROC | ZC_PROC_SPAWN_THREAD);
proc->caps_.AddNewCapabilityWithId(Z_INIT_VMAS_SELF, proc->vmas(),
Capability::ADDRESS_SPACE, ZC_WRITE);
proc->caps_.AddNewCapabilityWithId(Z_INIT_VMAS_SELF, proc->vmas(), ZC_WRITE);
return proc;
}
@ -77,31 +75,29 @@ uint64_t Process::AddCapability(const RefPtr<Capability>& cap) {
return caps_.AddExistingCapability(cap);
}
uint64_t Process::AddCapability(const RefPtr<Thread>& thread) {
return caps_.AddNewCapability(thread, Capability::THREAD, ZC_WRITE);
return caps_.AddNewCapability(thread, ZC_WRITE);
}
uint64_t Process::AddCapability(const RefPtr<Process>& proc) {
return caps_.AddNewCapability(proc, Capability::PROCESS,
ZC_WRITE | ZC_PROC_SPAWN_THREAD);
return caps_.AddNewCapability(proc, ZC_WRITE | ZC_PROC_SPAWN_THREAD);
}
uint64_t Process::AddCapability(const RefPtr<AddressSpace>& vmas) {
return caps_.AddNewCapability(vmas, Capability::ADDRESS_SPACE, ZC_WRITE);
return caps_.AddNewCapability(vmas, ZC_WRITE);
}
uint64_t Process::AddCapability(const RefPtr<MemoryObject>& vmmo) {
return caps_.AddNewCapability(vmmo, Capability::MEMORY_OBJECT, ZC_WRITE);
return caps_.AddNewCapability(vmmo, ZC_WRITE);
}
uint64_t Process::AddCapability(const RefPtr<Channel>& chan) {
return caps_.AddNewCapability(chan, Capability::CHANNEL, ZC_WRITE | ZC_READ);
return caps_.AddNewCapability(chan, ZC_WRITE | ZC_READ);
}
uint64_t Process::AddCapability(const RefPtr<Port>& port) {
return caps_.AddNewCapability(port, Capability::PORT, ZC_WRITE | ZC_READ);
return caps_.AddNewCapability(port, ZC_WRITE | ZC_READ);
}
void Process::AddCapability(uint64_t cap_id, const RefPtr<MemoryObject>& vmmo) {
caps_.AddNewCapabilityWithId(cap_id, vmmo, Capability::MEMORY_OBJECT,
ZC_WRITE);
caps_.AddNewCapabilityWithId(cap_id, vmmo, ZC_WRITE);
}