drew/acadia
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

Move many loops over glcr::Vector to range-based loops.

Browse source
This commit is contained in:
Drew Galbraith 2024-01-11 17:13:35 -08:00
parent c06d1741f3
commit b2354ae341
7 changed files with 18 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sys/denali/denali_server.cpp
View file

@ -39,8 +39,8 @@ glcr::Status DenaliServer::HandleReadMany(const ReadManyRequest& req,
}
uint64_t sector_cnt = 0;
for (uint64_t i = 0; i < req.sector_cnt().size(); i++) {
sector_cnt += req.sector_cnt().at(i);
for (uint64_t cnt : req.sector_cnt()) {
sector_cnt += cnt;
}
uint64_t region_paddr;
mmth::OwnedMemoryRegion region = mmth::OwnedMemoryRegion::ContiguousPhysical(

5
sys/teton/terminal.cpp
View file

@ -55,9 +55,8 @@ void Terminal::ExecuteCommand(const glcr::String& command) {
if (!files_or.ok()) {
console_.WriteString(glcr::StrFormat("Error: {}\n", files_or.error()));
} else {
auto& files = files_or.value();
for (uint64_t i = 0; i < files.size(); i++) {
console_.WriteString(files[i]);
for (const auto& file : files_or.value()) {
console_.WriteString(file);
console_.WriteChar('\n');
}
}

4
sys/victoriafalls/victoriafalls_server.cpp
View file

@ -94,8 +94,8 @@ glcr::Status VFSServer::HandleGetDirectory(const GetDirectoryRequest& request,
}
glcr::VariableStringBuilder filelist;
for (uint64_t i = 0; i < files.size(); i++) {
filelist.PushBack(glcr::StringView(files.at(i).name, files.at(i).name_len));
for (const DirEntry& file : files) {
filelist.PushBack(glcr::StringView(file.name, file.name_len));
filelist.PushBack(',');
}
// Remove trailing comma.

7
sys/yellowstone/yellowstone.cpp
View file

@ -47,10 +47,9 @@ uint64_t main(uint64_t port_cap) {
glcr::Vector<glcr::StringView> files =
glcr::StrSplit(init_file.as_str(), '\n');
for (uint64_t i = 0; i < files.size(); i++) {
if (!files[i].empty()) {
mmth::File binary =
mmth::File::Open(glcr::StrFormat("/bin/{}", files[i]));
for (glcr::StringView& file : files) {
if (!file.empty()) {
mmth::File binary = mmth::File::Open(glcr::StrFormat("/bin/{}", file));
ASSIGN_OR_RETURN(client_cap, server->CreateClientCap());
auto error_or = mmth::SpawnProcessFromElfRegion(