[zion] Add per-process CapabilityTable object

Store this information in it's own object to make the API clearer.
This commit is contained in:
Drew Galbraith 2023-06-16 14:25:45 -07:00
parent be12fa9a19
commit b4902a79ef
5 changed files with 119 additions and 68 deletions

View file

@ -0,0 +1,41 @@
#include "capability/capability_table.h"
CapabilityTable::CapabilityTable() {}
uint64_t CapabilityTable::AddExistingCapability(const RefPtr<Capability>& cap) {
MutexHolder h(lock_);
cap->set_id(next_cap_id_++);
capabilities_.PushBack(cap);
return cap->id();
}
RefPtr<Capability> CapabilityTable::GetCapability(uint64_t id) {
MutexHolder h(lock_);
auto iter = capabilities_.begin();
while (iter != capabilities_.end()) {
if (*iter && iter->id() == id) {
return *iter;
}
++iter;
}
dbgln("Bad cap access %u", id);
dbgln("Num caps: %u", capabilities_.size());
return {};
}
RefPtr<Capability> CapabilityTable::ReleaseCapability(uint64_t id) {
MutexHolder h(lock_);
auto iter = capabilities_.begin();
while (iter != capabilities_.end()) {
if (*iter && iter->id() == id) {
// FIXME: Do an actual release here.
auto cap = *iter;
*iter = {nullptr};
return cap;
}
++iter;
}
dbgln("Bad cap release: %u", id);
dbgln("Num caps: %u", capabilities_.size());
return {};
}

View file

@ -0,0 +1,54 @@
#pragma once
#include "capability/capability.h"
#include "lib/linked_list.h"
#include "lib/mutex.h"
#include "lib/ref_ptr.h"
class CapabilityTable {
public:
CapabilityTable();
CapabilityTable(CapabilityTable&) = delete;
CapabilityTable& operator=(CapabilityTable&) = delete;
template <typename T>
uint64_t AddNewCapability(const RefPtr<T>& object, Capability::Type type,
uint64_t permissions);
uint64_t AddExistingCapability(const RefPtr<Capability>& cap);
// FIXME: Remove reliance on this.
template <typename T>
void AddNewCapabilityWithId(uint64_t id, const RefPtr<T>& object,
Capability::Type type, uint64_t permissions);
RefPtr<Capability> GetCapability(uint64_t id);
RefPtr<Capability> ReleaseCapability(uint64_t id);
private:
Mutex lock_{"cap table"};
// FIXME: store this id here rather than in the capability.
uint64_t next_cap_id_ = 0x100;
// FIXME: use a map data structure.
LinkedList<RefPtr<Capability>> capabilities_;
};
template <typename T>
uint64_t CapabilityTable::AddNewCapability(const RefPtr<T>& object,
Capability::Type type,
uint64_t permissions) {
MutexHolder h(lock_);
uint64_t id = next_cap_id_++;
capabilities_.PushBack(
MakeRefCounted<Capability>(object, type, id, permissions));
return id;
}
template <typename T>
void CapabilityTable::AddNewCapabilityWithId(uint64_t id,
const RefPtr<T>& object,
Capability::Type type,
uint64_t permissions) {
capabilities_.PushBack(
MakeRefCounted<Capability>(object, type, id, permissions));
}